jakub/SubMusic
0
0
Fork 1
Code Issues 2 Pull requests Projects Releases 13 Packages Wiki Activity Actions

Login_page_improvements_and_threads_fix #15

Merged
jakub merged 7 commits from :Login_page_improvements_and_threads_fix into dev 2026-04-06 12:07:00 +00:00
Conversation 0 Commits 7 Files changed 6 +108 -55
pavel commented 2026-04-05 19:51:47 +00:00
Contributor
Copy link

Three things changed here:

  1. Fix for left behind threads: previously, if a connection was establishing and the user closed the app, zombie process was active (and draining battery significantly)
  2. Related to 1st – explicit timeout added in connection to not rely on TCP timeout.
  3. To use 2nd – login.cpp and communicator.cpp communication was wrapped in a future watcher and sharing statuses. This allows to emit loginFailed in case of generic errors not handled in the communicator.cpp
Three things changed here: 1. Fix for left behind threads: previously, if a connection was establishing and the user closed the app, zombie process was active (and draining battery significantly) 2. Related to 1st – explicit timeout added in connection to not rely on TCP timeout. 3. To use 2nd – login.cpp and communicator.cpp communication was wrapped in a future watcher and sharing statuses. This allows to emit loginFailed in case of generic errors not handled in the communicator.cpp
jakub deleted branch Login_page_improvements_and_threads_fix 2026-04-06 12:07:01 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jakub/SubMusic!15
No description provided.