Add all from current page is broken ? #25

Closed
opened 2026-04-10 16:53:22 +00:00 by jakub · 2 comments
Owner

We received a comment on sfos forum, that this function does not work. Please investigate.

Link: https://forum.sailfishos.org/t/is-there-no-subsonic-compatible-media-server-app-for-sfos/28381/13

We received a comment on sfos forum, that this function does not work. Please investigate. Link: https://forum.sailfishos.org/t/is-there-no-subsonic-compatible-media-server-app-for-sfos/28381/13
Contributor

I bet the reason is here: pavel/SubMusic@3e76dc0965/qml/pages/Main.qml (L212)

'Add' in label title (as it is done on dev branch) is misleading, and in fact 'Create from page' functionality for the regular usecase is not very useful: if as a user I've looked for 150 songs, which are displayed on three pages – I'd probably add them all to playlist, not only page 2 or page 3.

https://git.kiszczyc.pl/pavel/SubMusic/src/branch/Playlist_improvements – here I've changes behavior to not reset the playlist and actually add and I'd like to test it locally for some time, to catch possible issues because of lack of reset

I bet the reason is here: https://git.kiszczyc.pl/pavel/SubMusic/src/commit/3e76dc096558227ffe02e0322d3083f4801741fe/qml/pages/Main.qml#L212 'Add' in label title (as it is done on dev branch) is misleading, and in fact 'Create from page' functionality for the regular usecase is not very useful: if as a user I've looked for 150 songs, which are displayed on three pages – I'd probably add them all to playlist, not only page 2 or page 3. https://git.kiszczyc.pl/pavel/SubMusic/src/branch/Playlist_improvements – here I've changes behavior to not reset the playlist and actually add and I'd like to test it locally for some time, to catch possible issues because of lack of reset
Author
Owner

Closed via 1a2d0e3fc0

Closed via 1a2d0e3fc0
jakub closed this issue 2026-04-26 14:50:47 +00:00
Sign in to join this conversation.
No labels
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jakub/SubMusic#25
No description provided.