jakub/SubMusic
0
0
Fork 1
Code Issues 3 Pull requests 1 Projects Releases 13 Packages Wiki Activity Actions

Radio_and_Artist_page #39

Open
pavel wants to merge 12 commits from pavel/SubMusic:Radio_and_Artist_page into dev
pull from: pavel/SubMusic:Radio_and_Artist_page
merge into: jakub:dev
Conversation 1 Commits 12 Files changed 28 +1003 -694
pavel commented 2026-05-23 11:30:29 +00:00
Contributor
Copy link

Refactor: pull back the displayArtist priority over artist
Refactor: use C++ output in QML without mappings
Refactor: fix coverArt mapping. Pull back fallback artist mapping for Nextcloud
Refactor: clean up unused types
Refactor: streamline work with the communicator
Switch to the official MPRIS plugin
Feature: add initial Artist page. Scroll the playlist to the currently playing
Feature: add radiostations support

Refactor: pull back the displayArtist priority over artist Refactor: use C++ output in QML without mappings Refactor: fix coverArt mapping. Pull back fallback artist mapping for Nextcloud Refactor: clean up unused types Refactor: streamline work with the communicator Switch to the official MPRIS plugin Feature: add initial Artist page. Scroll the playlist to the currently playing Feature: add radiostations support
- Use timeout for all network calls;
- Limit sendRequest method to get request and return json;
- Move object validations to the calling method;
- Get rid of QNAM warnings from threads;
- Use getSong for starred status check;
- Use networkCommunicationFailed from communicator.h for all network errors;
- Reduce logic in getRandomSongs;
- Reduce conversions (string->Qstring->string and json->Song->QVariant);
- Map song/album/artist in a generic(ish) way
pavel force-pushed Radio_and_Artist_page from fa349e32fe to 4d531c0742 2026-05-23 22:40:41 +00:00 Compare
jakub approved these changes 2026-05-24 13:53:10 +00:00
This pull request can be merged automatically.
You are not authorized to merge this pull request.
View command line instructions

Checkout

From your project repository, check out a new branch and test the changes.
git fetch -u Radio_and_Artist_page:pavel-Radio_and_Artist_page
git switch pavel-Radio_and_Artist_page

Merge

Merge the changes and update on Forgejo.

Warning: The "Autodetect manual merge" setting is not enabled for this repository, you will have to mark this pull request as manually merged afterwards.

git switch dev
git merge --no-ff pavel-Radio_and_Artist_page
git switch pavel-Radio_and_Artist_page
git rebase dev
git switch dev
git merge --ff-only pavel-Radio_and_Artist_page
git switch pavel-Radio_and_Artist_page
git rebase dev
git switch dev
git merge --no-ff pavel-Radio_and_Artist_page
git switch dev
git merge --squash pavel-Radio_and_Artist_page
git switch dev
git merge --ff-only pavel-Radio_and_Artist_page
git switch dev
git merge pavel-Radio_and_Artist_page
git push origin dev
Sign in to join this conversation.
Reviewers
No reviewers
jakub
Labels
Clear labels
No items
No labels
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
jakub/SubMusic!39
No description provided.